Project

General

Profile

Actions

Incident #1511

closed

Report Manager - deactivating window.alert deactivates commit facility - Need for internal dialog

Added by Emmanuel Blondel almost 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Category:
Application
Target version:
Start date:
Nov 24, 2015
Due date:
% Done:

100%

Estimated time:
4.00 h
Infrastructure:
Development, Production

Description

Report Manager is using a window alert to ask for commit confirmation. Deactivating alerts (which is suggested by browsers with window.alert) prevents from commiting at all while it should triggers directly the commit confirmation. An internal dialog (as used for other UI components) might be used instead (not based on window.alert) to prevent this unexpected behavior.

Actions #1

Updated by Massimiliano Assante almost 10 years ago

Report Manager is using a standard Javascript Window.confirm, it is weird you get such a warning from the browser, what O.S. and Browser are you using, I'll try to reproduce

Actions #2

Updated by Massimiliano Assante almost 10 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Massimiliano Assante almost 10 years ago

  • Status changed from In Progress to Feedback
Actions #4

Updated by Emmanuel Blondel almost 10 years ago

I use Windows 7 - Google Chrome.
First time the window appears, Chrome doesn't ask you if you want to disable window alert windows. it does it at second commit.

Actions #5

Updated by Massimiliano Assante over 9 years ago

  • Status changed from Feedback to In Progress
Actions #6

Updated by Massimiliano Assante over 9 years ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100
  • Estimated time set to 4.00 h
  • Infrastructure deleted (Pre-Production)

The Reports Manager instance of development available at https://dev.d4science.org/group/devvre/report-generation contains the fix requested

In this moment however it seems VMEs do not get loaded due to an exception

Caused by: java.lang.NullPointerException
    at org.gcube.application.rsg.support.builder.impl.ReportManagerReportBuilder.getProperties(ReportManagerReportBuilder.java:639)
    at org.gcube.application.rsg.support.builder.impl.ReportManagerReportBuilder.getProperties(ReportManagerReportBuilder.java:583)
    at org.gcube.application.rsg.support.builder.impl.ReportManagerReportBuilder.addComponent(ReportManagerReportBuilder.java:293)
    at org.gcube.application.rsg.support.builder.impl.ReportManagerReportBuilder.addComponent(ReportManagerReportBuilder.java:236)
    ... 28 more

Actions #7

Updated by Massimiliano Assante over 9 years ago

  • Status changed from Feedback to Closed

org.gcube.portlets-user.report-generator-portlet.5-1-0 has been included in the next release (3.10)

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 8.91 MB)